Skip to main content

Calling 'BuildServiceProvider' from application code results in copy of Singleton warning in .Net Core


You will get this issue when you try to call the BuildServiceProvider() from the Startup.ConfigureServices method. The recommended solution is to use the IApplicationBuilder ApplicationServices to get the registered services in IServiceCollection. Calling BuildServiceProvider anywhere in your code is bad design as this might create additional singleton instances of services.

Each Service provider will have its own cache of singleton instances. If multiple service builders are created in code, it will cause the singleton instances to be created more than once, which contradicts the singleton property which is only once the instance is present throughout the lifetime of the application.

Please find the alternative solution below, when you want to get the registered services for dependency injection.

First, create a static class with a one property IServiceProvider type
public void ConfigureServices(IServiceCollection services)
{
    services.AddScoped<ILoggerEntry, LoggerEntry>();
    services.AddTransient<IMongoRepository, MongoRepository>();
}

Second, configure your services in ConfigureServices() method in Startup.cs and define the lifetime of the service instance using either Transient, Scoped or Singleton types.
public void ConfigureServices(IServiceCollection services)
{
   services.AddScoped<ILoggerEntry, LoggerEntry>();
   services.AddTransient<IMongoRepository, MongoRepository>();
}

Third, set the Static class provider property in Startup.Configure() method. ApplicationServices are used in situations where you need to get an instance of dependency service during the configuration phase. ApplicationServices are for the lifetime of the app.
public void Configure(IApplicationBuilder app, IWebHostEnvironment env)
        {
            StaticServiceProvider.Provider = app.ApplicationServices;
            if (env.IsDevelopment())
            {
                app.UseDeveloperExceptionPage();
            }
            app.UseHttpsRedirection();
            app.UseRouting();
            app.UseAuthorization();
            app.UseEndpoints(endpoints =>
            {
                endpoints.MapControllers();
            });
        }

That's it. You can now call GetService method almost anywhere in your application and get the service instance that you require using the GetService() method.
public static class StaticClass
    {
        private static IServiceProvider ServiceProvider 
          = StaticServiceProvider.Provider;
        private static ILoggerEntry loggerEntry = (ILoggerEntry)ServiceProvider?.GetService(typeof(ILoggerEntry));
        private static IMongoRepository mongoRepository 
          = (IMongoRepository)ServiceProvider?.GetService(typeof(IMongoRepository));

        public static string GetSubString(this string str)
        {
            loggerEntry.AddToLog("Inside Extension Method");
            return str.Substring(3);
        }
    }

Comments

Popular posts from this blog

How to clear Visual Studio Cache

How to clear visual studio cache Many times, during development you would face situations where project references are not loaded properly or you get missing/error DLL's. This is because the Component cache gets corrupted randomly and without any warnings. The first option that needs to be done is to clear component cache and restart Visual Studio since the Cache might be holding onto previous DLL versions. Here are the steps on how to clear Visual Studio Cache, Clearing Component Cache: Close all Visual Studio Instances running in your machine. Also, make sure devenv.exe is not running in the Task Manager Delete the Component cache directory - %USERPROFILE%\AppData\Local\Microsoft\VisualStudio\1x.0\ComponentModelCache Restart Visual Studio The above steps should fix the cache issue most of the times, but some times that is not enough and you need to perform the below steps as well. Clearing User's Temp Folder: Open the temp folder in this locatio n -  %USERPROFILE%\AppData\Loc

PCF Health Check Delay - Invocation timeout

In PCF we can set up the health check invocation timeout to execute X seconds after the instance has been created.  But before that, let's understand the PCF Health Check Lifecycle. Stage 1: The application is deployed to PCF Stage 2: When deploying the app, a health check type is specified and optionally a timeout. If a health check type is not specified, then the monitoring process defaults to a port health check Stage 3: Cloud Controller stages, starts, and runs the application Stage 4: Based on the type specified for the app, Cloud Controller configures a health check    that runs periodically for each app instance Stage 5: When Diego starts an app instance, the app health check runs every two seconds until a response indicates that the app instance is healthy or until the health check timeout elapses. The 2-seconds health check interval is not configurable Stage 6: When an app instance becomes healthy, its route is advertised, if applicable.                  Subsequent hea

How to dependency inject to static class

.Net core supports dependency injection. There are many ways that you can inject services like constructor injection, action method injection, property injection. But there will be scenarios where you need to inject dependency services to static classes. For example, injecting services to extension methods. First, create a static class with a one property IServiceProvider type public void ConfigureServices(IServiceCollection services) { services.AddScoped<ILoggerEntry, LoggerEntry>(); services.AddTransient<IMongoRepository, MongoRepository>(); } Second, configure your services in ConfigureServices() method in Startup.cs and define the lifetime of the service instance using either Transient, Scoped or Singleton types. public void ConfigureServices(IServiceCollection services) { services.AddScoped<ILoggerEntry, LoggerEntry>(); services.AddTransient<IMongoRepository, MongoRepository>(); } For the next step to configure the Static class provider proper